Skip to content

Conversation

@natalie-perlin
Copy link
Collaborator

Description

A hotfix for the Derecho new environment ncarenv/24.12,
as a follow-up to PR #1756

Fully external modulefile cray-mpich/8.1.29 is now used, and no separate spack-stack module is needed. All the external module dependencies are loaded by corresponding spack-stack meta-modules stack-cray-mpich/8.1.29.

Both "oneapi" and "gcc" unified environments are built correctly.
Test builds:
/glade/derecho/scratch/nperlin/spack-stack-R1.9.0/envs/ue-oneapi-2024.2.1
/glade/derecho/scratch/nperlin/spack-stack-R1.9.0/envs/ue-gcc-12.4
Logs attached below.

UFS-WM successfully builds and runs with the new spack-stack environment (log from a compile_s2swa_intel build job attached below)

Dependencies

If there are PRs that need to be merged before or along with this one, please add "- [ ] waiting on LINK_TO_PR" for each of them.

Issues addressed

ufs-community/ufs-weather-model#2033
ufs-community/ufs-weather-model#2177

A PR opened to the weather model (still in draft form); the issues are solved with the Derecho spack-stack 1.9.x new environment, ncarenv/24.12:

ufs-community/ufs-weather-model#2863

Applications affected

List all known applications (UFS WM, JEDI, SRW, etc.) intentionally or unintentionally affected by this PR.

Systems affected

  • Derecho

Testing

Some of the logs (build stage log is too large to be attached):
log.concretize.ue-oneapi.txt
spack.lock_ue-oneapi.txt
log.concretize.ue-gcc.txt
spack.lock_ue-gcc.txt

compile_s2swa_intel.out.txt
cpld_control_ciceC_p8_intel.err.txt

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a nutshell, you are reverting the majority of the changes from the previous PR and the resulting config is very similar (with a few important modifications) to what I created for develop a while back.

I will create a PR to update the derecho config accordingly, except for the changes that do not make sense (you don't need to load the compiler module as part of the mpi modules, because spack loads those for building, and spack-stack when setting up user environments).

@climbfuji
Copy link
Collaborator

@natalie-perlin Ready for merging?

@natalie-perlin
Copy link
Collaborator Author

@climbfuji - yes, ready for merging

@climbfuji
Copy link
Collaborator

@climbfuji - yes, ready for merging

Thanks! Awesome

@natalie-perlin
Copy link
Collaborator Author

@climbfuji - thank you for your comments,
I hope this sounds like a more acceptable solution, fully utilizing system-wide installed modules

@climbfuji climbfuji merged commit b9fc93e into JCSDA:release/1.9.0 Aug 29, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants